XMMS2 - ISSUES

0002345: add and server import don't canonicalize paths.

Because of that, a same file can be added several times when added with relative paths from several working directories.

0002270: Inconvenient and arbitrary output line length limited to 80 characters for non-terminal output

andrew@happy:~$ XMMS_PATH=tcp://192.168.55.2:9667 [^] nyxmms2 status -f '"${title}","${album}","${artist}","${url}"'
Creating /home/andrew/.config/xmms2/clients/nycli.conf...
Error: Can't create configuration file!
"Concerto F major : III Allegro","Six Cello Concertos, Hogwood (AAM) - Christophe Coin","Antonio Vivaldi","file:///music/Classified/Classical/Antonio_Vivaldi/Six_Cello_Concertos%2c_Hogwood_%28AAM%29_-_Christophe_Coin/12-Concerto_F_major_:_III_Allegro.ogg" [^]

vs:

andrew@happy:~$ XMMS_PATH=tcp://192.168.55.2:9667 [^] nyxmms2 status -f '"${title}","${album}","${artist}","${url}"' | cat
Creating /home/andrew/.config/xmms2/clients/nycli.conf...
Error: Can't create configuration file!
"Concerto C minor : I Allegro non molto","Six Cello Concertos, Hogwood (AAM) - Candrew@happy:~$

(note that output is truncated without a trailing newline, too)

0002344: crash when deserialising unavailable collections from disk

my laptop crashes sometimes, with encrypted home this can lead to broken files, where the encryption layer returns ioerror. S4 assumes that the file can be read and crashes on NULL. There are two occurances where returnvalue of file operations aren't checked, in collserial.c iirc.

0002343: sorting removes duplicates in the playlist

add the same song a couple of times, and perform a sort on the playlist, now you will only have unique songs in the playlist.

0001065: daap: support password shares

Password protected shares should probably be handled in someway.

0002342: playlist resizing shouldn't be continous

At the moment the playlist is resized continous, but it should be resized in about 13 pixels at a time

0002341: Mousewheel in the main windows should adjust volume

At the moment, the mouse wheel only adjusts the volume if the mouse is placed above the volume slider.
Like in xmms the volume should be adjusted if the mouse wheel is used anywhere in the main window

0002340: Add option to disable the tooltips in the playlist window

It should be possible to disable the tooltips in the playlist window

0002339: Playlist resizing doesn't work under the "Awesome" window manager

Playlist window's sizer doesn't work under the "Awesome" window manager (it
shrinks the playlist window down to the minimum size.) Using AwesomeWM's
shortcuts it can be resized successfully. Not sure which package is
responsible for the bug, it does work properly under the Compiz window manager.

0001061: make titlebar dragable

make it able to drag the titlebar.

0002276: flv song length incorrect

[13:51:40][nano-]: agg: wrong duration on flv files.
[13:51:49][nano-]: agg: Playing: videoplayback%3fip%3d0.0.0.0%26sparams%3did%252Cexpire%252Cip%252Cipbits%252C...: 00:15 of 16:02
[13:51:58][nano-]: agg: when it's only about 3 minutes long
[13:52:18][nano-]: agg:
http://v4.cache2.c.youtube.com/videoplayback?ip=0.0.0.0&sparams=id%2Cexpire%2Cip%2Cipbits%2Citag%2Cburst%2Cfactor&fexp=903206&itag=5&ipbits=0&signature=0CE8BC119019687778785CE36D897E7941360F98.3B386FB0C93061FC914EE926630BDDC32FEB3448&sver=3&expire=1254420000&key=yt1&factor=1.25&burst=40&id=eeb9e88e2d5cd90e&redirect_counter=1 [^]
[19:03:44][agg] nano-: Yeah, I would write a parser for the info tag, but mpg123/mad set the duration themselves.
[19:04:00][agg]: It's something wrong on that side I think.
[19:06:07][nano-]: agg: aha
[19:39:45][wanders] nano-: agg: mad uses filelength to calculate duration.
[01:26:43][agp]: agg: i LURV U
[01:26:50][agp]: agg: BUT U GAVE ME AIDS
[01:28:32][agg]: O_O

0002338: Strange behavior when trying to add non-audio files

$ nyxmms2 add cover.jpg
$ nyxmms2 list
...
[9/] - ()

0002336: PLAYBACK_SEEK constants are missing

playback_seek_ms_rel and playback_seek_samples_rel were deprecated, but the constants XMMS_PLAYBACK_SEEK_CUR and XMMS_PLAYBACK_SEEK_SET for the "new" seek function are not available.

Please add XMMS_PLAYBACK_SEEK_SET and XMMS_PLAYBACK_SEEK_CUR to xmmsclient.consts in python.

0002335: Optimize $prop:* in the collparser

Instead of matching with a glob expression, $prop:* could simply use the Has operator on the property, so:

artist:* <=> +artist

This could result in quite dramatic performance improvement (both sqlite and S4).

0002287: Monkey's Audio crash on playback

Playing a certain .ape file causes a segfault:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7f44d6aff910 (LWP 32068)]
0x00007f44dd738900 in CAPETag::GetHasID3Tag (this=0xffffffffd00b18a0) at /usr/include/mac/APETag.h:254
254 BOOL GetHasID3Tag() { if (m_bAnalyzed == FALSE) { Analyze(); } return m_bHasID3Tag; }
Current language: auto; currently c++
(gdb) bt
#0 0x00007f44dd738900 in CAPETag::GetHasID3Tag (this=0xffffffffd00b18a0) at /usr/include/mac/APETag.h:254
0000001 0x00007f44dd738203 in xmms_mac_get_media_info (xform=0x7f44d00aa790) at ../src/plugins/mac/mac.cpp:198
0000002 0x00007f44dd7387b3 in xmms_mac_init (xform=0x7f44d00aa790) at ../src/plugins/mac/mac.cpp:145
0000003 0x0000000000428333 in xmms_xform_new (plugin=0x1a3b300, prev=0x7f44d00aa2d0, entry=5319, goal_hints=0x1b7c540) at ../src/xmms/xform.c:408
0000004 0x000000000042a03a in xmms_xform_find (prev=0x7f44d00aa2d0, entry=5319, goal_hints=0x1b7c540) at ../src/xmms/xform.c:1308
0000005 0x000000000042a433 in chain_setup (entry=5319, url=0x7f44d00c3340 "file://.ape", [^] goal_formats=0x1b7c540) at ../src/xmms/xform.c:1450
0000006 0x000000000042a646 in xmms_xform_chain_setup_url (entry=5319, url=0x7f44d00c3340 "file://.ape", [^] goal_formats=0x1b7c540, rehash=0) at ../src/xmms/xform.c:1525
0000007 0x000000000042a5fe in xmms_xform_chain_setup (entry=5319, goal_formats=0x1b7c540, rehash=0) at ../src/xmms/xform.c:1510
0000008 0x0000000000417cfb in xmms_output_filler (arg=0x7f44d0000b80) at ../src/xmms/output.c:420
0000009 0x00007f44e9eb9d2b in ?? () from /usr/lib/libglib-2.0.so.0
0000010 0x00007f44e93c82c7 in start_thread () from /lib/libpthread.so.0
0000011 0x00007f44e91385dd in clone () from /lib/libc.so.6
0000012 0x0000000000000000 in ?? ()
(gdb) print *this
Cannot access memory at address 0xffffffffd00b18a0
(gdb) fr 1
0000001 0x00007f44dd738203 in xmms_mac_get_media_info (xform=0x7f44d00aa790) at ../src/plugins/mac/mac.cpp:198
198 BOOL bHasID3Tag = p_ape_tag->GetHasID3Tag ();
(gdb) print p_ape_tag
$1 = (CAPETag *) 0xffffffffd00b18a0

0002334: connection to server will not be closes

If you create a XMMS object and connect to the server, the connection will not be closed if you delete or unref the object.

This leads to many open connections to the xmms2-server and after enough connections it simply will crash.

0002333: introduce xmmsc_playback_current_info

As mentioned in the comments of 0002013 we have a concept of volatile data in the daemon. This includes the chain attribute, shoutcast metadata, lyrics etc. This data doesn't make sense to store in the media library. One way would be to introduce a xmmsc_playback_current_info call (in contrast to xmmsc_medialib_get_info). This would provide both persistent and volatile metadata of the current playing entry.

0002261: combining a Collection with None causes Segfault

It's easy to reproduce:

>>> import xmmsclient.collections as xc
>>> coll = xc.Universe() & None
Segmentation fault

Doesn't make any sense, of course. But it still shouldn't crash.

0002328: shared library of the ruby bindings are installed to wrong directory

The ruby shared library is installed to the wrong directory.
Instead of RUBY_ARCHDIR LIBDIR is used as install target.
Because of that, the --with-ruby-archdir also does nothing

0002316: race condition in xmms_object_ref/_unref

calling xmms_object_ref/xmms_object_unref can lead to a race condition that crashes xmms2d.

0002317: Coreaudio plugin won't load on OS X 10.5.8

The coreaudio plugin from DrM+WIP+TEST1 builds fine but won't load on OS X 10.5.8.

0002327: 'add .' adds a buggy entry in the playlist

$ nyxmms2 add .
$ nyxmms2 list
->[1/] - ()

'add .' adds a buggy entry in the playlist.

0002320: [PATCH] Fix Wavpack segfault on open failure

The wavpack plugin doesn't check to see if the file was opened successfully, so if there's a failure it passes a NULL pointer around which eventually causes a crash.

The attached patch fixes the issue. I will also attach a file that reproduces the problem.

0002315: xmms2-libvisual: xmmsv_unref was called with a freed value

$ xmms2-libvisual
Controls: Arrow keys switch between plugins, TAB toggles fullscreen, ESC quits.
Each plugin can has its own mouse/key bindings, too.
Note: you can give your favourite libvisual plugin as command line argument.
******
* xmmsv_unref was called with a freed value
* This is probably an error in the application using libxmmsclient
******

0002306: sc68 ym/paula plugin

A plugin that uses sc68 2.3.0 to play ym and paula chiptunes (*.sc68 and *.snd files.)