XMMS2 - ISSUES

0002389: unable to use HTTP / curl failiure

Both getting playlist from http and playing icecast/shoutcast streams fails on my system. Curl support is enabled and gvfs disabled.

I have gentoo ~amd64 with xmms2-0.7-r2 (r2 is revision of ebuild not xmms FWIU) and curl-7.21.0

% nyxmms2 addpls http://slayradio.org/tune_in.php/128kbps/listen.m3u [^]
Server error: We can't handle this type of playlist or URL
--- log ---
12:08:29 DEBUG: ../src/xmms/ipc.c:551: Client connected
12:08:29 DEBUG: ../src/xmms/main.c:315: Client 'xmms2-nycli' connected
12:08:29 DEBUG: ../src/xmms/ipc.c:551: Client connected
12:08:29 DEBUG: ../src/xmms/main.c:315: Client 'xmms2-nycli-sync' connected
12:08:29 DEBUG: ../src/xmms/xform.c:290: url = http://slayradio.org/tune_in.php/128kbps [^]
12:08:29 DEBUG: ../src/xmms/xform.c:1274: Trying plugin 'visualization'
...
12:08:29 DEBUG: ../src/xmms/xform.c:1274: Trying plugin 'curl'
12:08:29 DEBUG: ../src/xmms/xform.c:1277: Plugin 'curl' matched (priority 50)
...
12:08:29 DEBUG: ../src/xmms/xform.c:301: found xform curl
12:08:29 DEBUG: ../src/xmms/xform.c:356: Freeing xform 'curl'
12:08:29 DEBUG: ../src/xmms/xform.c:356: Freeing xform 'unknown'
...
12:08:29 DEBUG: ../src/xmms/xform.c:1277: Plugin 'curl' matched (priority 50)
12:08:29 DEBUG: ../src/plugins/curl/curl_http.c:222: Using version 7.21.0 of libcurl
12:08:39 DEBUG: ../src/xmms/xform.c:356: Freeing xform 'curl'
12:08:39 ERROR: ../src/xmms/xform.c:1453: Couldn't set up chain for 'http://slayradio.org/tune_in.php/128kbps/listen.m3u' [^] (1)
12:08:39 DEBUG: ../src/xmms/xform.c:356: Freeing xform 'unknown'
Failed in file ../src/lib/xmmstypes/value.c on row 204
12:08:39 DEBUG: ../src/xmms/ipc.c:347: disconnect was true!
12:08:39 DEBUG: ../src/xmms/ipc.c:461: Destroying client!
12:08:39 DEBUG: ../src/xmms/ipc.c:347: disconnect was true!
12:08:39 DEBUG: ../src/xmms/ipc.c:461: Destroying client!

% xmms2 add http://relay3.slayradio.org:8000/ [^]
Added http://relay3.slayradio.org:8000/ [^]
% nyxmms2 play

--- log ---
12:17:20 DEBUG: ../src/xmms/ipc.c:551: Client connected
12:17:20 DEBUG: ../src/xmms/main.c:315: Client 'xmms2-cli' connected
12:17:20 DEBUG: ../src/xmms/playlist.c:209: PLAYLIST: updated chg!
12:17:20 DEBUG: ../src/xmms/ipc.c:347: disconnect was true!
12:17:20 DEBUG: ../src/xmms/ipc.c:461: Destroying client!
12:17:30 DEBUG: ../src/xmms/collsync.c:65: Syncing collections to database.
12:17:52 DEBUG: ../src/xmms/ipc.c:551: Client connected
12:17:52 DEBUG: ../src/xmms/main.c:315: Client 'xmms2-nycli' connected
12:17:52 DEBUG: ../src/xmms/ipc.c:551: Client connected
12:17:52 DEBUG: ../src/xmms/main.c:315: Client 'xmms2-nycli-sync' connected
...
12:17:52 DEBUG: ../src/xmms/xform.c:1277: Plugin 'curl' matched (priority 50)
...
12:17:52 DEBUG: ../src/plugins/curl/curl_http.c:222: Using version 7.21.0 of libcurl
12:18:02 DEBUG: ../src/xmms/collsync.c:65: Syncing collections to database.
12:18:02 DEBUG: ../src/xmms/xform.c:356: Freeing xform 'curl'
12:18:02 ERROR: ../src/xmms/xform.c:1453: Couldn't set up chain for 'http://relay3.slayradio.org:8000/' [^] (24)
12:18:02 DEBUG: ../src/xmms/xform.c:356: Freeing xform 'unknown'
12:18:02 DEBUG: ../src/xmms/playlist.c:199: PLAYLIST: updated pos!
12:18:02 DEBUG: ../src/xmms/output.c:469: End of playlist
12:18:02 DEBUG: ../src/xmms/outputplugin.c:272: Running status changed... 0
12:18:02 DEBUG: ../src/plugins/alsa/alsa.c:376: audio device closed.

0002386: libcurl plugin is unable to handle some web headers responses?!

Hello,

Looks like libcurl is unable to load m3u playlist from some web servers. If I download the file locally - chain is created successfully. I guess libcurl plugin does not recognize some web servers responses. Some are working some are not. Below I am giving example of working and not working one.

0002388: Recursive directory add to playlist

I do miss the "radd" function as it did exists in the old xmms2 client

0002383: seeking does not work with modplug plugin

As the description says, you cannot seek when playing MOD files with modplug.

libmodplug does provide a method for seeking in mod files and though it's (said to be) inaccurate, having inaccurate seeking is still better than having no seeking at all.

0002387: Relative volume change

It should be possible to set the volume relative to the current value.

Examples:

xmms2> server volume +10
xmms2> server volume -10

0002385: Missing check for sqlite3 headers

waf configure doesn't seem to check for the presence of sqlite3 headers, so if the sqlite3-dev package (or whatever) is absent, compilation fails, rather than the configuration stage.

0002384: xmms2d refuses to start, because xmms2d is build against 2.18 runtime is 2.16

xmms2d refuses to start:

$ xmms2d
xmms2d is build against version 2.18,
but is (runtime) linked against 2.16.
Refusing to start.

Please drop the check, because it should only require to use a glib version that has the same ABI. The glib version 2.16 and 2.18 in Debian has the same ABI and therefore xmms2d should run with 2.16, too.

0002382: unable to set playlist history

xmms2> playlist config
name: Default
type: queue
history: (null)
xmms2> playlist config -s 2
--history flag only valid for queue and pshuffle playlists!
xmms2> playlist config --history 2
--history flag only valid for queue and pshuffle playlists!

0000208: env.checklibs() fails on FLAC library

env.checklibs("FLAC", "FLAC__seekable_stream_decoder_get_state") in src/plugins/flac/Plugin fails because the math library isn't being linked into the check/test program (-lm is missing). Adding it to the env won't help the check since that's not included in the test program.

Using Gentoo Linux and FLAC version 1.1.0

0000513: can't compile with FAAD support

Really strange error messages in config.log file (attached), and as a result - no faad support.

e.g.:
/usr/lib/gcc-lib/i586-suse-linux/3.3.3/../../../libfaad.so: undefined reference
to `sqrt'

I suspect there's something with faad or system libs (glibc?) here. How come it can't find 'sqrt'? :-)

0002381: avcodec's "read the whole packet" doesn't compatible with xmms_xform_read() ?

While I'm debugging with tta plugin (see http://bugs.xmms2.xmms.se/view.php?id=2380), [^] I find another strange behavior of the return value of xmms_xform_read().

From src/xmms/xform.c line 1003 to 1019:

if (read == 0)
xmms_xform_hotspots_update (xform);

if (!g_queue_is_empty (xform->hotspots)) {
if (xform->buffered + res > xform->buffersize) {
xform->buffersize = MAX (xform->buffersize * 2,
xform->buffersize + res);
xform->buffer = g_realloc (xform->buffer,
xform->buffersize);
}

g_memmove (xform->buffer + xform->buffered, buf + read, res);
xform->buffered += res;
break; /* break even if read < siz ?! */
}
read += res;

when "break" happens in the invocation of xmms_xform_read() called by xmms_avcodec_read(), it buffered parts of the data, but then the return value is not the request size, then in xmms_avcodec_read() it thinks that the whole packet is already read, however it is not the case. I can't come up with a easy solution without modifying xmms_xform_read().

Since I'm not familiar with the architecture of xmms2, maybe this situation never happens, I need your conclusion.

0002380: tta plugin doesn't work with segment with startms (or simply .cue)

avcodec will only decode the first frame. When it comes to the second frame, unexpected behavior happened with plugins/avcodec/avcodec.c line 282 to line 335.

By the comments in the code, /* If we have a demuxer plugin, make sure we read the whole packet */, but at line 292

bytes_read = xmms_xform_read (xform,
(gchar *) data->buffer,
data->buffer_size,
error);

it returns an obviously wrong value.

I find that it's because in function xmms_tta_seek at plugins/tta/tta.c, it forgets to reset
data->next_boundary = 0;
after data->nextframe is set.

0002379: Improving documentation on Ruby bindings

Currently documentation on Ruby bindings is a little bit lacking. I've gathered some info that is available at http://xmms2.org/wiki/Component:Ruby_bindings [^] and its subpages. There could be more info but I haven't used other functions yet so I don't have that information.

I've changed rb_playlist.c, rb_xmmsclient.c, and xmmsclient.rb in src/clients/lib/ruby.

I've attached these changed files in zip archive for now. Should I attach files separately? Please advice if it should be in some different format like diff, online git tree, or whatever else. Please mention how to do that too just in case. Thank you.

0002378: normalize plug-in does not support 8 and 32 bit samples format

normalize plug-in does not support 8 and 32 bit samples format.
The ugliest attached patch adds support of missed formats.
(patch is really ugliest, but IMHO can be used as temporary solution)
PS: I did not test 8 bit format.

0002377: mac plug-in does not support 24-bit Monkey's Audio files

mac plug-in does not support 24-bit Monkey's Audio files,
but used mac library allows to do it.
Attached patch resolves this problem.

0002376: segment plug-in causes crush server

segment plug-in causes crush server when you play big high resolution files with cue.
For example: 192000 Hz, 2 ch, s32le, 27 minutes.
The problem is function ms_to_bytes (result type integer is not enough to
present distance in bytes for such files).
Attached patch resolves this problem.

0002375: alsa plug-in does not support all sample rates provided by alsa library

alsa plug-in does not support all sample rates provided by alsa library.
There are missed 12, 24, 32, 88.2, 176.4 192 kHz.
Attached patch adds missed frequencies.

0002373: Duplicate entries in mlib after xmms2 add, due to relpath/filename and ./relpath/filename

When I use xmms2 add to add directorys xmms2d doesn't add already existent entries to its medialib.
When using . as relative path operator it failes doing this

Here's a example:

$ xmms2 add OhJonnyBassIllEuroRemix.mp3
$ xmms2 list
->[1/5143] - Oh Jonny _BASS ILL EURO Remix_ mastered (06:11)

Total playtime: 0:06:11
$ xmms2 add OhJonnyBassIllEuroRemix.mp3 # works correct here
$ xmms2 list
->[1/5143] - Oh Jonny _BASS ILL EURO Remix_ mastered (06:11)
[2/5143] - Oh Jonny _BASS ILL EURO Remix_ mastered (06:11)

Total playtime: 0:12:23
$ xmms2 add ./OhJonnyBassIllEuroRemix.mp3 # fails, 5143 != 5345
$ xmms2 list
->[1/5143] - Oh Jonny _BASS ILL EURO Remix_ mastered (06:11)
[2/5143] - Oh Jonny _BASS ILL EURO Remix_ mastered (06:11)
[3/5345] - Oh Jonny _BASS ILL EURO Remix_ mastered (06:11)

Total playtime: 0:18:34

0002374: xmms2d crashes after logout

When running a xmms2d remote it crashes with the following message: "16:14:14 FATAL: ../src/xmms/sqlite.c:523: Error opening sqlite db: unable to open database file"

0002372: Please clarify license for mind.in.a.box-lament_snipplet.ogg

According to COPYING mind.in.a.box-lament_snipplet.ogg should be licensed under LGPL, but http://www.mindinabox.com/ [^] offers non-free (in terms of freedom) songs. do mind in a box permit derivative works of this snipplet? Please mention the license for this file clearly in COPYING.

0002187: XMMS.coll_list() should append namespace to names when called without argument or *

>>> import os, xmmsclient
>>> xm = xmmsclient.XMMSSync()
>>> xm.connect(os.getenv('XMMS_PATH'))
>>> xm.coll_list('Playlists')
[u'Name1', u'Name2']
>>> xm.coll_list('Collections')
[u'Name2', u'Name3', u'Name4']
>>>xm.coll_list()
[u'Name1', u'Name2', u'Name2', u'Name3', u'Name4']

This makes coll_list a bit useless without any argument. I would expect this:
>>>xm.coll_list()
[u'Playlists/Name1', u'Playlists/Name2', u'Collections/Name2', u'Collections/Name3', u'Collections/Name4']

0002051: calling xmms2 mlib add from find -exec caused mlib corruption

I was having problems with the xmms2 mlib addpath command so i tried to add all the songs separatly using

find Music -exec xmms2 mlib add \{\} \;

during the add process i ran

xmms2 search \*

after some time into the search process xmms spammed the terminal with lines on the form

Log output will be stored in /home/johan/.cache/xmms2/xmms2d.log
startup failed!
ERROR: Could not connect to xmms2d: Disconnected
ERROR: Sql error/corruption selecting max(id)

the last line repeadted loots of times betwean the other two.

I then interupted the find process ^C and when i tried to use the media lib after that I got

johan@cyclop:~$ xmms2 mlib search "artist:*"
ERROR: Error in query: no such table: Media
johan@cyclop:~$

0002329: 'playlist config' doesn't support the jumplist property.

the command "playlist config" should have an option (-j,--jumplist) to allow the user to set the jumplist property.

Current behavior:
xmms2> playlist config Foo
name: Foo
type: list
xmms2> collection config Playlists/Foo jumplist Foo2
xmms2> playlist config Foo
name: Foo
type: list

Expected behavior:
xmms2> playlist config Foo
name: Foo
type: list
xmms2> playlist config -t list -j Foo2 Foo
xmms2> playlist config Foo
name: Foo
type: list
jumplist: Foo2

0002370: the media-updateter should look for moved filed

When one move a file or a directory in paths that are watched by the medialib updater, the medialib entries for the old position are destroy, and new one are created, loosing all meta-information the medialib might contain.

glib can offer way to detect those move, and should it when it can.

0002371: the medialib updater try to add severall time the same files

When starting, xmms2-mlib-updater add to its watch list all subdirectories of the watched directory, and for all them use the xmmsc_medialib_import_path to add their content to the medialib.

The problem is that xmmsc_medialib_import_path do recursively import a directory, so it should not be called on all subdirectories, but only on the root one.