0002191: xmmsclient-cf.h: wrong decl, s/xmmsc_ipc_setup_with_cf/xmmsc_setup_with_cf/

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0002191

[XMMS2] clientlib

minor

N/A

09-03-15 20:34

10-02-20 15:09

Reporter

p00ya

View Status

public

Assigned To

nano

Priority

normal

Resolution

fixed

Status

resolved

Product Version

0.5 DrLecter

Summary

0002191: xmmsclient-cf.h: wrong decl, s/xmmsc_ipc_setup_with_cf/xmmsc_setup_with_cf/

Description

xmmsc_ipc_setup_with_cf is declared in xmmsclient-cf.h. This symbol is not defined, but xmmsc_setup_with_cf (defined in xmmsclient-cf.c) is probably what is wanted.

It definitely isn't there:
% grep -lr xmmsc_ipc_setup_with_cf xmms2-0.5DrLecter
xmms2-0.5DrLecter/src/include/xmmsclient/xmmsclient-cf.h

% nm -g -s __TEXT __text libxmmsclient-cf.dylib

/opt/local/lib/libxmmsclient-cf.dylib(single module):
00000e56 T _xmmsc_io_cf_toggle_socket_flags
00000eed T _xmmsc_setup_with_cf

(trivial) patch attached.

Additional Information

Tags

No tags attached.

GIT commit id

3ab1c686d6aa3a5e98b0c690da62f1c42566d837

Has patch

Yes, needs review

Attached Files

xmms2-xmmsclient-cf.patch [^] (402 bytes) 09-03-15 20:34

Relationships [ Relation Graph ] [ Dependency Graph ]

There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
09-03-15 20:34	p00ya	New Issue
09-03-15 20:34	p00ya	File Added: xmms2-xmmsclient-cf.patch
09-03-15 20:34	p00ya	Has patch	=> Yes, needs review
09-03-16 11:04	p00ya	Issue Monitored: p00ya
09-06-28 14:17	nano	GIT commit id	=> 3ab1c686d6aa3a5e98b0c690da62f1c42566d837
09-06-28 14:17	nano	Status	new => resolved
09-06-28 14:17	nano	Fixed in Version	=> 0.7 DrN
09-06-28 14:17	nano	Resolution	open => fixed
09-06-28 14:17	nano	Assigned To	=> nano
09-06-28 14:17	nano	Target Version	=> 0.7 DrN
10-02-20 11:38	nano	Target Version	0.7 DrN => 0.8 DrO
10-02-20 15:07	nano	Target Version	0.8 DrO => 0.7 DrN

Mantis 1.1.6[^]