0002222: Fails to add non-browseable URIs containing * or ? with nycli

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0002222

[XMMS2] nycli client

major

always

09-05-21 01:32

10-01-26 12:39

Reporter

theefer

View Status

public

Assigned To

anders

Priority

normal

Resolution

fixed

Status

resolved

Product Version

0.6 DrM

Summary

0002222: Fails to add non-browseable URIs containing * or ? with nycli

Description

(reported by AnthonyG)

Looks like all URIs get greedily passed to the matching_browse function, which uses the xmmsc_xform_media_browse_encoded to expand * and ? wildcards. Except URLs such as http://www.example.com/?foo=bar [^] also become candidate for expansion, even though the ? is not a wildcard and the protocol is now browseable.

We somehow need to differentiate the case when those symbols are part of the URI vs when they are used as wildcards. Might be able to use the protocol or its "browseability" for that? Also need to check that it's possible to escape those characters (e.g. file containing ? or *).

Additional Information

Tags

Has patch, need review

GIT commit id

dcbdaa8524c4a498ebdc971963a8e1a9e87bdc7b

Has patch

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0003918) AnthonyG (developer) 09-08-15 11:43	Fixed in my tree.

(0004063) automatic (developer) 10-01-25 21:00	commit dcbdaa8524c4a498ebdc971963a8e1a9e87bdc7b Author: Anthony Garcia <anthony@agg.homelinux.net> AuthorDate: Sat Jan 23 11:37:11 2010 -0700 Commit: Anders Waldenborg <andersg@xmms.org> CommitDate: Mon Jan 25 20:58:58 2010 +0100 BUG(2222): nycli fails to add non-browseable URLs containing '*' /or '?'

Issue History
Date Modified	Username	Field	Change
09-05-21 01:32	theefer	New Issue
09-05-21 01:50	theefer	Summary	Cannot add non-browseable URIs with nycli => Fails to add non-browseable URIs containing * or ? with nycli
09-05-21 01:50	theefer	Description Updated
09-05-22 21:23	AnthonyG	Issue Monitored: AnthonyG
09-08-15 11:41	AnthonyG	Status	new => confirmed
09-08-15 11:41	AnthonyG	Tag Attached: Has patch
09-08-15 11:41	AnthonyG	Tag Attached: need review
09-08-15 11:43	AnthonyG	Note Added: 0003918
10-01-25 21:00	automatic	Checkin
10-01-25 21:00	automatic	Note Added: 0004063
10-01-26 12:39	anders	GIT commit id	=> dcbdaa8524c4a498ebdc971963a8e1a9e87bdc7b
10-01-26 12:39	anders	Status	confirmed => resolved
10-01-26 12:39	anders	Resolution	open => fixed
10-01-26 12:39	anders	Assigned To	=> anders

Mantis 1.1.6[^]