| Anonymous | Login | Signup for a new account | 10-09-09 07:08 CEST |
| Main | My View | View Issues | Change Log | Roadmap | Docs |
| Viewing Issue Simple Details [ Jump to Notes ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||
| ID | Category | Severity | Reproducibility | Date Submitted | Last Update | ||
| 0002320 | [XMMS2] plugins | crash | always | 10-01-30 05:23 | 10-02-20 15:09 | ||
| Reporter | Malvineous | View Status | public | ||||
| Assigned To | tilman | ||||||
| Priority | normal | Resolution | fixed | ||||
| Status | resolved | Product Version | 0.6 DrM | ||||
| Summary | 0002320: [PATCH] Fix Wavpack segfault on open failure | ||||||
| Description |
The wavpack plugin doesn't check to see if the file was opened successfully, so if there's a failure it passes a NULL pointer around which eventually causes a crash. The attached patch fixes the issue. I will also attach a file that reproduces the problem. |
||||||
| Additional Information |
Tested against 0.6 DrMattDestruction+WIP+TEST1 (ed20112bf0d42989689282be2eab44c7891f4547) |
||||||
| Tags | No tags attached. | ||||||
| GIT commit id | 27d6f199a487178dacab8a995e885bb5058aadc0 | ||||||
| Has patch | Yes, needs review | ||||||
| Attached Files |
 wavpack_handle_open_failure.patch [^] (630 bytes) 10-01-30 05:23 test.wvc [^] (10,240 bytes) 10-01-30 05:24 |
||||||
|
|
|||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
|
Notes |
|
|
(0004079) tilman (administrator) 10-01-30 14:40 |
Looks good, thanks. Pushed to xmms2-tilman. |
|
(0004082) automatic (developer) 10-01-31 22:04 |
commit 27d6f199a487178dacab8a995e885bb5058aadc0 Author: Adam Nielsen <a.nielsen@shikadi.net> AuthorDate: Sat Jan 30 14:39:20 2010 +0100 Commit: Tilman Sauerbeck <tilman@xmms.org> CommitDate: Sat Jan 30 14:39:20 2010 +0100 BUG(2320): Fixed a segfault in the wavpack plugin on open failure. |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 10-01-30 05:23 | Malvineous | New Issue | |
| 10-01-30 05:23 | Malvineous | File Added: wavpack_handle_open_failure.patch | |
| 10-01-30 05:23 | Malvineous | Has patch | => Yes, needs review |
| 10-01-30 05:24 | Malvineous | File Added: test.wvc | |
| 10-01-30 06:06 | Malvineous | Issue Monitored: Malvineous | |
| 10-01-30 14:40 | tilman | Note Added: 0004079 | |
| 10-01-31 22:04 | automatic | Checkin | |
| 10-01-31 22:04 | automatic | Note Added: 0004082 | |
| 10-02-01 17:37 | caotic | GIT commit id | => 27d6f199a487178dacab8a995e885bb5058aadc0 |
| 10-02-01 17:37 | caotic | Resolution | open => fixed |
| 10-02-01 17:37 | caotic | Fixed in Version | => 0.7 DrN |
| 10-02-01 17:37 | caotic | Target Version | => 0.7 DrN |
| 10-02-03 18:07 | tilman | Status | new => resolved |
| 10-02-03 18:07 | tilman | Assigned To | => tilman |
| 10-02-20 11:38 | nano | Target Version | 0.7 DrN => 0.8 DrO |
| 10-02-20 15:07 | nano | Target Version | 0.8 DrO => 0.7 DrN |
| Mantis 1.1.6[^] Copyright © 2000 - 2008 Mantis Group |  |
