0000250: Loss of precision due to replaygain plugin

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0000250

[XMMS2] plugins

minor

always

05-07-12 19:00

05-12-23 12:01

Reporter

jlt

View Status

public

Assigned To

Priority

normal

Resolution

open

Status

confirmed

Product Version

0.1 DR2

Summary

0000250: Loss of precision due to replaygain plugin

Description

Since rounding is done in the decoder plugins (in the case of mad 24->16 bit) information that could be used to maintain maximum 16bit quality (e.g. use the complete 16bit range) in the replaygain plugin is lost.

Also should at one point the maximum_peak information provided in some mp3s be used. The streams arriving at the plugin will already have distortions due to clipping.

Suggested solution:
a) Provide a function set_scaling() in the decoder plugins which can than be called by the replay_gain, etc. plugins.
b) Do not do any clipping in the decoder plugin. Instead do it when all plugins have been applied.

a) is probably more efficient, while b) seems to be cleaner.

Additional Information

Tags

No tags attached.

GIT commit id

Has patch

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

child of

0000520

feedback

Long term wishlist.

There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
05-07-12 19:00	jlt	New Issue
05-07-12 19:00	jlt	Fix before version	=> Unknown
05-12-22 22:01	andersg	Relationship added	child of 0000520
05-12-23 12:01	andersg	Status	new => confirmed

Mantis 1.1.6[^]